Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: xml syntax error in bom/README.md #372

Merged
merged 1 commit into from
Oct 18, 2019
Merged

docs: xml syntax error in bom/README.md #372

merged 1 commit into from
Oct 18, 2019

Conversation

BenWhitehead
Copy link
Contributor

Originally proposed in #371

@BenWhitehead BenWhitehead requested a review from a team October 18, 2019 17:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2019
@BenWhitehead BenWhitehead mentioned this pull request Oct 18, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

Merging #372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #372   +/-   ##
=========================================
  Coverage     79.67%   79.67%           
  Complexity      389      389           
=========================================
  Files            27       27           
  Lines          1761     1761           
  Branches        183      183           
=========================================
  Hits           1403     1403           
  Misses          262      262           
  Partials         96       96
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 83.45% <0%> (ø) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f02de9...e0d225a. Read the comment docs.

chingor13
chingor13 reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is probably better labeled as docs:

@BenWhitehead BenWhitehead merged commit ff8606a into master Oct 18, 2019
@BenWhitehead BenWhitehead deleted the BenWhitehead-patch-1 branch October 18, 2019 18:09
@BenWhitehead BenWhitehead changed the title fix: xml syntax error in bom/README.md docs: xml syntax error in bom/README.md Oct 18, 2019
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenWhitehead @chingor13 @JustinBeckwith @googlebot