fix: remove 1 hour limit for the impersonated token #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Thanks @shinfan. Do we know which SDK release will include this change, and when will it be released to the maven repo? |
Cloud IAM now supports extended 12h lifespan for access token.
chingor13
approved these changes
Oct 15, 2020
chingor13
changed the title
chingor13
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
|
Do we need to cut a release for this fix? @chingor13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud IAM now supports extended 12h lifespan for access token:
https://cloud.google.com/iam/docs/creating-short-lived-service-account-credentials#sa-credentials-oauth
A separate PR should be made to allow developers to specify the desired lifespan of the granted token.