Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update gcp-metadata to catch a json-bigint security fix #1078

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

feywind
Copy link
Contributor

@feywind feywind commented Oct 16, 2020

Fixes: googleapis/nodejs-pubsub#1121

A pub/sub user reported a security vulnerability being pulled in through google-auth-library-nodejs -> gcp_metadata -> json_bigint. This just bumps the minimum gcp_metadata to pull that in.

@feywind feywind requested a review from a team as a code owner October 16, 2020 22:28
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2020
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #1078 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files          21       21           
  Lines        4145     4145           
  Branches      497      497           
=======================================
  Hits         3801     3801           
  Misses        344      344           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1893b1...bff627f. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 125fe09 into googleapis:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@google-cloud/pubsub@2.5.0 includes dependencies with security vulnerabilities
3 participants