Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support AWS_DEFAULT_REGION for determining AWS region #1149

Merged
merged 2 commits into from
Mar 23, 2021
Merged

fix: support AWS_DEFAULT_REGION for determining AWS region #1149

merged 2 commits into from
Mar 23, 2021

Conversation

bojeil-google
Copy link
Contributor

AWS_DEFAULT_REGION is also a supported environment variable for the AWS region:
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html

Priority order for region determination:
AWS_REGION > AWS_DEFAULT_REGION > AWS metadata server

`AWS_DEFAULT_REGION` is also a supported environment variable for the AWS region:
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html

Priority order for region determination:
AWS_REGION > AWS_DEFAULT_REGION > metadata server
@bojeil-google bojeil-google requested a review from a team as a code owner March 18, 2021 08:23
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #1149 (3b5dff4) into master (99cfba4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1149   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          28       28           
  Lines        6257     6260    +3     
  Branches      655      656    +1     
=======================================
+ Hits         5866     5869    +3     
  Misses        391      391           
Impacted Files Coverage Δ
src/auth/awsclient.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cfba4...3b5dff4. Read the comment docs.

@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9ae2d30 into googleapis:master Mar 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants