feat: Implement DownscopedClient#getAccessToken() and unit test #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-auth-library-nodejs into xinxinxin-iamSetUp
…-auth-library-nodejs into xinxinxin-iamSetUp
google-cla
bot
added
the
cla: yes
SurferJeffAtGoogle
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
SurferJeffAtGoogle
approved these changes
Jun 30, 2021
|
@xil222 thank you for the contribution 👏 excited for this. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 30, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [7.2.0](https://www.github.com/googleapis/google-auth-library-nodejs/compare/v7.1.2...v7.2.0) (2021-06-30) ### Features * Implement DownscopedClient#getAccessToken() and unit test ([#1201](https://www.github.com/googleapis/google-auth-library-nodejs/issues/1201)) ([faa6677](https://www.github.com/googleapis/google-auth-library-nodejs/commit/faa6677fe72c8fc671a2190abe45897ac58cc42e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
| public readonly eagerRefreshThresholdMillis: number; | ||
| public readonly forceRefreshOnFailure: boolean; | ||
|
|
||
| constructor( |
There was a problem hiding this comment.
I think we need to allow the quota_project_id to be provided as optional in the header. You can add this later though.
There was a problem hiding this comment.
I'll add this part as well as test for headers during full implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DownscopedClient class getAccessToken() API and related unit tests.
Design Doc: link