Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Retryable interface for token endpoint requests #1366

Closed
TimurSadykov opened this issue Feb 16, 2022 · 3 comments · Fixed by #1791
Closed

Implement Retryable interface for token endpoint requests #1366

TimurSadykov opened this issue Feb 16, 2022 · 3 comments · Fixed by #1791
Assignees
@danielbankhead
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@TimurSadykov
Copy link
Member

Currently, clients do not have a good way to distinguish retryable errors and implement custom retry strategies. Sometimes this causes infinite retries like here: https://github.com/nwbirnie/gapic-oauth-invalid-hangs. Please prioritize the fix if similar infinite retry is repro here as well.

More details in the doc: go/auth-correct-retry
@TimurSadykov TimurSadykov added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 16, 2022
@danielbankhead danielbankhead self-assigned this Aug 25, 2022
@danielbankhead danielbankhead mentioned this issue Nov 29, 2023
Closed
@danielbankhead
Copy link
Contributor

Related:

@TimurSadykov
Copy link
Member Author

@danielbankhead is it still open or fixed with the attached PR?

@danielbankhead
Copy link
Contributor

@TimurSadykov Still open, made some progress in the other PR

This was referenced Apr 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbankhead danielbankhead

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Enable Retries For Auth Requests googleapis/google-auth-library-nodejs
2 participants
@TimurSadykov @danielbankhead