Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn when using Cloud SDK creds if quota_project_id is set #833

Closed
broady opened this issue Nov 22, 2019 · 0 comments · Fixed by #905
Closed

Don't warn when using Cloud SDK creds if quota_project_id is set #833

broady opened this issue Nov 22, 2019 · 0 comments · Fixed by #905
Assignees
@JustinBeckwith
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@broady
Copy link
Contributor

broady commented Nov 22, 2019

Here: https://github.com/googleapis/google-auth-library-nodejs/blob/3646b7f9deb296aaff602dd2168ce93f014ce840/src/auth/googleauth.ts#L427:13
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Nov 23, 2019
@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 27, 2019
@yoshi-automation yoshi-automation removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Nov 27, 2019
@JustinBeckwith JustinBeckwith mentioned this issue Feb 29, 2020
Merged
@JustinBeckwith JustinBeckwith self-assigned this Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not warn for SDK creds googleapis/google-auth-library-nodejs
4 participants
@broady @bcoe @JustinBeckwith @yoshi-automation