Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: populate x-goog-user-project for requestAsync #837

Merged
merged 1 commit into from
Dec 2, 2019
Merged

feat: populate x-goog-user-project for requestAsync #837

merged 1 commit into from
Dec 2, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Nov 26, 2019 •
edited
Loading

In writing smoke tests for google-api-nodejs-client, I found that our apiary library uses the requestAsync code path, rather than the getRequestHeaders code path.

This PR:

  • moves the logic for header population into getRequestMetadataAsync, which is called in both places.
  • populates the header requestAsync.
  • adds a regression test.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2019
@bcoe bcoe mentioned this pull request Nov 26, 2019
Merged
@JustinBeckwith JustinBeckwith merged commit 5a068fb into master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@broady broady Awaiting requested review from broady

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcoe @JustinBeckwith @googlebot