feat: support for verifying ES256 and retrieving IAP public keys #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bshaffer
force-pushed
the
es256-verify
branch
from
f25a409 to
7bf13f4
Compare
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
suggested changes
Feb 10, 2020
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
=======================================
Coverage 90.84% 90.84%
=======================================
Files 19 19
Lines 4218 4218
Branches 452 452
=======================================
Hits 3832 3832
Misses 380 380
Partials 6 6Continue to review full report at Codecov.
|
|
@bcoe I reviewed your changes, PTAL! |
bcoe
approved these changes
Feb 12, 2020
This was referenced Feb 13, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 14, 2020
This PR was generated using Autosynth. 🌈 Commits in this repo since last synth: c532b14 chore(deps): update dependency linkinator to v2 (#886) a98e386 feat: support for verifying ES256 and retrieving IAP public keys (#887) e671629 build: add GitHub actions config for unit tests (#888) 163e43d test: modernize mocha config (#884) 58e5029 chore: skip img.shields.io in docs test 13e8cfb chore(deps): update dependency @types/mocha to v7 634cf6a chore: release 5.9.2 (#882) 63c4637 fix: populate credentials.refresh_token if provided (#881) <details><summary>Log from Synthtool</summary> ``` synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py. On branch autosynth nothing to commit, working tree clean HEAD detached at FETCH_HEAD nothing to commit, working tree clean .eslintignore .eslintrc.yml .github/ISSUE_TEMPLATE/bug_report.md .github/ISSUE_TEMPLATE/feature_request.md .github/ISSUE_TEMPLATE/support_request.md .github/PULL_REQUEST_TEMPLATE.md .github/release-please.yml .github/workflows/ci.yaml .jsdoc.js .kokoro/common.cfg .kokoro/continuous/node10/common.cfg .kokoro/continuous/node10/docs.cfg .kokoro/continuous/node10/lint.cfg .kokoro/continuous/node10/samples-test.cfg .kokoro/continuous/node10/system-test.cfg .kokoro/continuous/node10/test.cfg .kokoro/continuous/node12/common.cfg .kokoro/continuous/node12/test.cfg .kokoro/continuous/node8/common.cfg .kokoro/continuous/node8/test.cfg .kokoro/docs.sh .kokoro/lint.sh .kokoro/presubmit/node10/common.cfg .kokoro/presubmit/node10/docs.cfg .kokoro/presubmit/node10/lint.cfg .kokoro/presubmit/node10/samples-test.cfg .kokoro/presubmit/node10/system-test.cfg .kokoro/presubmit/node10/test.cfg .kokoro/presubmit/node12/common.cfg .kokoro/presubmit/node12/test.cfg .kokoro/presubmit/node8/common.cfg .kokoro/presubmit/node8/test.cfg .kokoro/presubmit/windows/common.cfg .kokoro/presubmit/windows/test.cfg .kokoro/publish.sh .kokoro/release/docs.cfg .kokoro/release/docs.sh .kokoro/release/publish.cfg .kokoro/samples-test.sh .kokoro/system-test.sh .kokoro/test.bat .kokoro/test.sh .kokoro/trampoline.sh .nycrc .prettierignore .prettierrc CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE README.md codecov.yaml renovate.json samples/README.md synthtool > Wrote metadata to synth.metadata. ``` </details>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 20, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [5.10.0](https://www.github.com/googleapis/google-auth-library-nodejs/compare/v5.9.2...v5.10.0) (2020-02-20) ### Features * support for verifying ES256 and retrieving IAP public keys ([#887](https://www.github.com/googleapis/google-auth-library-nodejs/issues/887)) ([a98e386](https://www.github.com/googleapis/google-auth-library-nodejs/commit/a98e38678dc4a5e963356378c75c658e36dccd01)) ### Bug Fixes * **docs:** correct links in README ([f6a3194](https://www.github.com/googleapis/google-auth-library-nodejs/commit/f6a3194ff6df97d4fd833ae69ec80c05eab46e7b)), closes [#891](https://www.github.com/googleapis/google-auth-library-nodejs/issues/891) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
samples/verifyIdToken-iap.jsto see this in use.Allows for the IAP public keys to be used to verify IAP-signed tokens. See this tutorial for more info