From 3078367d24e451c73cf13edd24be5ce8661795f8 Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Fri, 2 Feb 2024 10:43:15 -0800 Subject: [PATCH 1/2] fix: Allow Get Universe Without Credentials --- src/auth/googleauth.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/auth/googleauth.ts b/src/auth/googleauth.ts index aca320ac..472ae789 100644 --- a/src/auth/googleauth.ts +++ b/src/auth/googleauth.ts @@ -343,7 +343,12 @@ export class GoogleAuth { let universeDomain = originalOrCamelOptions(this.clientOptions).get( 'universe_domain' ); - universeDomain ??= (await this.getClient()).universeDomain; + try { + universeDomain ??= (await this.getClient()).universeDomain; + } catch { + // client or ADC is not available + universeDomain ??= DEFAULT_UNIVERSE; + } return universeDomain; } From 4d27d4e4deaa2d93ba111f61ecaee675f304fa3c Mon Sep 17 00:00:00 2001 From: Daniel Bankhead Date: Fri, 2 Feb 2024 10:46:40 -0800 Subject: [PATCH 2/2] chore: Pin `karma` --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 8e7814ff..ac6ef892 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "karma-firefox-launcher": "^2.0.0", "karma-mocha": "^2.0.0", "karma-sourcemap-loader": "^0.4.0", - "karma-webpack": "^5.0.0", + "karma-webpack": "5.0.0", "keypair": "^1.0.4", "linkinator": "^4.0.0", "mocha": "^9.2.2",