Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't open browser if port is occupied #92

Merged
merged 8 commits into from
Oct 28, 2020
Merged

fix: don't open browser if port is occupied #92

merged 8 commits into from
Oct 28, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Oct 23, 2020 •
edited
Loading

Set allow_reuse_address to False so a server is not created on a port that is already in use.

wsgiref.simple_server.WSGIServer.allow_reuse_address = False

Also a laundry list of changes to make this repo consistent with others:

  • adds generic repo templates via synthtool
  • replaces tox with nox
  • use Kokoro instead of Travis
  • Drops support for EOL Python versions (python < 3.5)

Fixes #75

@busunkim96 busunkim96 requested a review from a team as a code owner October 23, 2020 20:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2020
tswast
tswast approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@busunkim96 busunkim96 merged commit 0004057 into master Oct 28, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 28, 2020
@release-please
chore: release 0.4.2 (#93)
7638659 
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.4.2](https://www.github.com/googleapis/google-auth-library-python-oauthlib/compare/v0.4.1...v0.4.2) (2020-10-28)


### Bug Fixes

* don't open browser if port is occupied ([#92](https://www.github.com/googleapis/google-auth-library-python-oauthlib/issues/92)) ([0004057](https://www.github.com/googleapis/google-auth-library-python-oauthlib/commit/00040576ab096faec1f6eb54c886cb9c33be17ed)), closes [#75](https://www.github.com/googleapis/google-auth-library-python-oauthlib/issues/75)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@harshjadon9
Copy link

harshjadon9 commented Feb 9, 2021 •
edited
Loading

wsgiref.simple_server.WSGIServer.allow_reuse_address = False

where should i paste it in WSGI.py? @tswast @busunkim96
i m using django, apache

@tswast tswast deleted the fail-if-port-occupied branch February 17, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run_local_server should fail fast if the requested port is already used
3 participants
@busunkim96 @harshjadon9 @tswast