Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it is better to keep expiry data from oauth2session #18

Closed
andytzeng opened this issue Nov 3, 2017 · 2 comments
Closed

it is better to keep expiry data from oauth2session #18

andytzeng opened this issue Nov 3, 2017 · 2 comments
Assignees
@theacodes
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@andytzeng
Copy link
Contributor

the helper function credentials_from_session helps to generate Credentials object from session. But, it does not carry expires_at data from oauth2session.token

It is better that the expiry can be carried to Credentials object. So, caller can check expired property of Credentials to know whether the token expired.

Thanks.
@theacodes theacodes added the bug label Nov 3, 2017
@theacodes
Copy link

@andytzeng good point! Would you be willing to send a PR to do this? It seems like an easy fix.

@andytzeng
Copy link
Contributor Author

sure, I can do that

andytzeng pushed a commit to andytzeng/google-auth-library-python-oauthlib that referenced this issue Nov 6, 2017
carry token expiry into Credentials object (googleapis#18)
9362f7b
andytzeng added a commit to andytzeng/google-auth-library-python-oauthlib that referenced this issue Nov 6, 2017
@andytzeng
carry token expiry into Credentials object (googleapis#18)
f5bb83d
theacodes pushed a commit that referenced this issue Nov 9, 2017
@andytzeng
Carry token expiry from oauth2session into Credentials object (#18) (#19
f26bcba 
)
theacodes pushed a commit that referenced this issue Nov 10, 2017
@andytzeng
Populate id_token into credentials from oauth2 session (#20)
f1c87ff 
* carry token expiry into Credentials object (#18)

* populate id_token into credentials (#9)
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theacodes theacodes

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@theacodes @andytzeng @yoshi-automation