feat: pluggable auth support #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md feat: Add Pluggable auth support (#988) * Port identity pool credentials * access_token retrieved * -> pluggable * Update pluggable.py * Create test_pluggable.py * Unit tests * Address pr issues feat: Add file caching (#990) * Add file cache * feat: add output file cache support 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Update pluggable.py 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Update pluggable.py Update setup.py 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Update setup.py Update setup.py pytest_subprocess timeout Update pluggable.py env 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Update _default.py 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Update requirements.txt Update _default.py Update pluggable.py Update pluggable.py Update pluggable.py Update test_pluggable.py format validations Update _default.py Update requirements.txt 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Revert "Update requirements.txt" This reverts commit 1c9b6db. Revert "Update _default.py" This reverts commit ac6c360. Revert "Revert "Update _default.py"" This reverts commit 1c08483. Raise output format error but retry parsing token if `success` is 0 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Update requirements.txt Delete test_pluggable.py Revert "Delete test_pluggable.py" This reverts commit 74beba9. Update pluggable.py Update pluggable.py pytest-subprocess 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md lint Update pluggable.py nox cover nox cover 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md lint Update test_pluggable.py Update test_pluggable.py
renkelvin
added
the
do not merge
renkelvin
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
Update noxfile.py
|
You can copy the docs I wrote in googleapis/google-auth-library-java#921 |
1 similar comment
|
You can copy the docs I wrote in googleapis/google-auth-library-java#921 |
added 2 commits
May 31, 2022 10:42
mik-laj
reviewed
May 31, 2022
google/auth/pluggable.py
Outdated
| - `$POOL_ID`: The workload identity pool ID. | ||
| - `$PROVIDER_ID`: The OIDC or SAML provider ID. | ||
| - `$SERVICE_ACCOUNT_EMAIL`: The email of the service account to impersonate. | ||
| - `SUBJECT_TOKEN_TYPE`: The subject token type. |
There was a problem hiding this comment.
Suggested change
| - `SUBJECT_TOKEN_TYPE`: The subject token type. | |
| - `$SUBJECT_TOKEN_TYPE`: The subject token type. |
|
Hey @arithmetic1728 , could you help take a look at the CI issues? For the docs-presubmit, it looks something wrong with the config? I reverted all the changes locally but the issue persisted. For the Kokoro system-3.7 issue, looks like it's the same issue of expired token as before. Thanks! |
|
@renkelvin The fix is in #1047 The system test credential expires roughly every 2 days, I will update it again once your PR is ready for checking in. You can ignore the system-3.7 failure during the code review. |
lsirac
approved these changes
Jun 1, 2022
arithmetic1728
approved these changes
Jun 2, 2022
lsirac
reviewed
Jun 9, 2022
lsirac
reviewed
Jun 10, 2022
renkelvin
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate Pluggable Auth PR
The 1st commit(52f6950) is squashed from the PR approved before(#995)
The 2nd commit(a8c53f8) disabled pluggable auth for Python 2
test_pluggable.pyfor unit tests in Python 2