Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Async certificate retrieving #1101

Merged
merged 6 commits into from
Aug 18, 2022
Merged

Fix: Async certificate retrieving #1101

merged 6 commits into from
Aug 18, 2022

Conversation

tivaliy
Copy link
Contributor

@tivaliy tivaliy commented Aug 6, 2022

This PR fixes bug reported in #1100

@tivaliy tivaliy requested review from arithmetic1728, sai-sunder-s and a team as code owners August 6, 2022 11:20
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 7, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 7, 2022
@clundin25
Copy link
Contributor

clundin25 commented Aug 15, 2022 •
edited
Loading

Looks good. I have one minor outstanding comment.

Thanks for this contribution!

@clundin25 clundin25 added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 15, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 16, 2022
@clundin25 clundin25 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@clundin25 clundin25 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 16, 2022
@clundin25 clundin25 added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@clundin25 clundin25 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 18, 2022
@clundin25 clundin25 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2022
@clundin25 clundin25 merged commit 05f125d into googleapis:main Aug 18, 2022
@release-please release-please bot mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25 clundin25 approved these changes

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

@sai-sunder-s sai-sunder-s Awaiting requested review from sai-sunder-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tivaliy @clundin25 @parthea @yoshi-kokoro