Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding more properties to external_account_authorized_user #1169

Merged
merged 10 commits into from
Oct 29, 2022
Merged

fix: adding more properties to external_account_authorized_user #1169

merged 10 commits into from
Oct 29, 2022

Conversation

ScruffyProdigy
Copy link
Contributor

No description provided.

@ScruffyProdigy ScruffyProdigy requested a review from lsirac October 25, 2022 17:44
@ScruffyProdigy ScruffyProdigy added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2022
@ScruffyProdigy ScruffyProdigy added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 27, 2022
BigTailWolf
BigTailWolf approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@BigTailWolf BigTailWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TimurSadykov
TimurSadykov approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with couple error messages suggestions

google/auth/external_account_authorized_user.py Outdated Show resolved Hide resolved
google/auth/external_account_authorized_user.py Show resolved Hide resolved
@ScruffyProdigy ScruffyProdigy added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 29, 2022
@ScruffyProdigy ScruffyProdigy added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2022
@ScruffyProdigy ScruffyProdigy added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 29, 2022
@ScruffyProdigy ScruffyProdigy added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 29, 2022
@ScruffyProdigy ScruffyProdigy merged commit a12b96d into googleapis:main Oct 29, 2022
@ScruffyProdigy ScruffyProdigy deleted the props branch October 29, 2022 06:02
@release-please release-please bot mentioned this pull request Oct 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsirac lsirac lsirac approved these changes

@BigTailWolf BigTailWolf BigTailWolf approved these changes

@TimurSadykov TimurSadykov TimurSadykov approved these changes

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

@sai-sunder-s sai-sunder-s Awaiting requested review from sai-sunder-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScruffyProdigy @TimurSadykov @BigTailWolf @lsirac @yoshi-kokoro