fix: Make external_account resistant to string type 'expires_in' responses from non-compliant services #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' responses from non-compliant services
clundin25
approved these changes
Sep 5, 2023
BigTailWolf
approved these changes
Sep 6, 2023
|
@clundin25 do I have to run the checks manually, or do they run automatically? |
clundin25
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
clundin25
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
clundin25
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
|
Thanks @clundin25 ! |
|
Hi @duzun, My tentative answer is next week on Monday or Tuesday, given that there are a lot of changes staged and it's near the end of the work week. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make external_account resistant to string type 'expires_in' responses from non-compliant services.
This is to complete #1208.
A client run into this error.