feat: adding domain-wide delegation flow in impersonated credential #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecificed for domain-wide delegation auth.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
brianhmj
changed the title
…ecificed for domain-wide delegation auth.
sai-sunder-s
reviewed
Nov 4, 2024
arithmetic1728
approved these changes
Jan 9, 2025
|
@brianhmj Could you test the code end to end manually to make sure it works? |
…ecificed for domain-wide delegation auth.
…/google-auth-library-python into dwdthroughimpersonation
arithmetic1728
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
arithmetic1728
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
arithmetic1728
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
arithmetic1728
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of moving away from service account keys, Domain Wide Delegation is used locally by impersonating a service account and then generating credentials with a signed jwt with the sub field of the principal. While it is supported through service account credentials, this is currently not supported by the impersonation in python google auth library.
Added the flow(https://cloud.google.com/iam/docs/best-practices-for-managing-service-account-keys#domain-wide-delegation) that allows users to create credentials with DWD through impersonation.
Similar implementation can be found in the Go auth library:
https://github.com/googleapis/google-api-go-client/blob/v0.201.0/impersonate/impersonate.go#L98