Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make verify_oauth2_token check the issuer claim #499

Closed
anguillanneuf opened this issue May 5, 2020 · 0 comments · Fixed by #500
Closed

Make verify_oauth2_token check the issuer claim #499

anguillanneuf opened this issue May 5, 2020 · 0 comments · Fixed by #500
Assignees
@anguillanneuf
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@anguillanneuf
Copy link
Contributor

It doesn't look like the Python library checks for the issuer claim as it does for other language libraries (Node.js).

It would make the Google authentication instructions here more consistent across if verify_oauth2_token checks both "accounts.google.com" and "https://accounts.google.com".
@anguillanneuf anguillanneuf changed the title Check the issuer claim Make verify_oauth2_token check the issuer claim May 5, 2020
@busunkim96 busunkim96 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 6, 2020
@busunkim96 busunkim96 mentioned this issue May 6, 2020
Merged
@anguillanneuf anguillanneuf mentioned this issue May 6, 2020
Merged
@kevinthecheung kevinthecheung mentioned this issue May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anguillanneuf anguillanneuf

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@busunkim96 @anguillanneuf