Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add quota_project_id to service accounts; add with_quota_project methods #519

Merged
merged 5 commits into from
Jun 10, 2020
Merged

feat: add quota_project_id to service accounts; add with_quota_project methods #519

merged 5 commits into from
Jun 10, 2020

Conversation

busunkim96
Copy link
Contributor

Adds quota_project_id to service account credentials, making it possible to set quota_project_id on OAuth2 credentials and service account credentials.

This PR also adds the method with_quota_project to both classes.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2020
@busunkim96
Copy link
Contributor Author

busunkim96 commented Jun 4, 2020 •
edited
Loading

@broady @bshaffer I think I should expand this PR so all credentials produced by the default auth flow have quota_project (+ App Engine and Compute Engine credentials).

Is it appropriate to add quota_project_id to the base credentials class? I'm curious what other languages did.

@busunkim96 busunkim96 mentioned this pull request Jun 4, 2020
Closed
2 tasks
software-dov
software-dov approved these changes Jun 5, 2020
View reviewed changes
Copy link

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the copy_docstring bit I don't understand.

google/oauth2/service_account.py Show resolved Hide resolved
@software-dov software-dov added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 10, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 10, 2020
@software-dov software-dov added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 10, 2020
@software-dov software-dov merged commit b12488c into master Jun 10, 2020
This was referenced Jun 11, 2020
Merged
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 21, 2020
@busunkim96
test: add more tests for service account quota projects (#527)
18d5ae6 
Follow up to #519
@tseaver tseaver deleted the more-quota-project-id branch October 28, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@software-dov software-dov software-dov approved these changes

@broady broady Awaiting requested review from broady

@bshaffer bshaffer Awaiting requested review from bshaffer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @software-dov @googlebot @yoshi-kokoro