Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fetch_id_token credential lookup order to match adc #748

Merged
merged 9 commits into from
Jul 14, 2021

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented May 5, 2021

fix: #747 #663 #728

(1) switch the metadata server and GOOGLE_APPLICATION_CREDENTIALS lookup order to match the adc order
(2) fix the metadata server exception by first sending a ping to metadata server to make sure metadata server exists

Tested on compute engine with this sample, and both service account json file and compute engine credentials.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2021
@arithmetic1728 arithmetic1728 marked this pull request as ready for review May 6, 2021 21:42
@arithmetic1728 arithmetic1728 requested a review from a team as a code owner May 6, 2021 21:42
@arithmetic1728 arithmetic1728 merged commit c34452e into master Jul 14, 2021
@arithmetic1728 arithmetic1728 deleted the fix_idtoken branch July 14, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication priority issue with fetch_id_token
2 participants