fix: enforce constraints during unit tests #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop explicit pin / constraint on 'urllib3': specific 'requests' versions have very narrow pins, and ours is only likely to create conflicts. Bump the 'requests' lower bound to '2.20.0', the lowest version for which our tests pass once constraints are being checked. Closes #759
google-cla
bot
added
the
cla: yes
jimfulton
approved these changes
May 25, 2021
| @@ -123,7 +132,7 @@ def cover(session): | |||
| "--cov=google.oauth2", | |||
| "--cov=tests", | |||
| "--cov=tests_async", | |||
| "--cov-report=", | |||
| "--cov-report=term-missing", | |||
There was a problem hiding this comment.
If lines aren't being covered, then the report should include them, so that the hapless developer can figure out why. I've never understood why that isn't the default behavior for the report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop explicit pin / constraint on
urllib3: specificrequestsversions have very narrow pins, and ours is only likely to create conflicts.Bump the
requestslower bound to2.20.0, the lowest version for which our tests pass once constraints are being checked.Closes #759