Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptography int_from_bytes is deprecated #902

Closed
jgriffith-cp opened this issue Oct 28, 2021 · 1 comment · Fixed by #904
Closed

cryptography int_from_bytes is deprecated #902

jgriffith-cp opened this issue Oct 28, 2021 · 1 comment · Fixed by #904
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jgriffith-cp
Copy link

Error: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead

google-auth-library-python/google/auth/crypt/es256.py

Line 56 in 77d7f1b

r = utils.int_from_bytes(sig_bytes[:32], byteorder="big")

Environment details

  • OS: Ubuntu 20.04.3
  • Python version: 3.8.10
  • pip version: 20.0.2
  • google-auth version: 2.3.2

Steps to reproduce

  1. install google auth using pip
  2. Python: from google.oauth2 import service_account
@busunkim96
Copy link
Contributor

@arithmetic1728 I think this got re-added with the 2.7 re-shuffle for gcloud. Can the logic be adjusted so Python 3 users don't see the deprecating warning? (original fix was in #846 and #848)

@busunkim96 busunkim96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 29, 2021
@arithmetic1728 arithmetic1728 mentioned this issue Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use 'int.to_bytes' and 'int.from_bytes' for py3 googleapis/google-auth-library-python
2 participants
@busunkim96 @jgriffith-cp