Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OTel tracing decorator to storage::ReadObjectSource #11393

Closed
coryan opened this issue Apr 26, 2023 · 1 comment · Fixed by #14435
Closed

Add OTel tracing decorator to storage::ReadObjectSource #11393

coryan opened this issue Apr 26, 2023 · 1 comment · Fixed by #14435
Assignees
@coryan
Labels
api: storage Issues related to the Cloud Storage API. cpp: opentelemetry type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Member

coryan commented Apr 26, 2023

We need to create a span that covers the full download.
@coryan coryan added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. cpp: opentelemetry labels Apr 26, 2023
@dbolduc
Copy link
Member

dbolduc commented Jan 24, 2024

Ping @dbolduc

@dbolduc dbolduc removed their assignment Jul 1, 2024
@coryan coryan self-assigned this Jul 3, 2024
@coryan coryan mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
api: storage Issues related to the Cloud Storage API. cpp: opentelemetry type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(storage): single span for ReadObject() coryan/google-cloud-cpp
2 participants
@coryan @dbolduc