-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CI tests linking against current code as DLL #4090
Labels
type: cleanup
An internal cleanup or hygiene concern.
Comments
Changed the title because we have a build for |
Dropping this. Can reconsider when our deps (e.g. protobuf) support compiling as DLL. |
See #5849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to:
Originally posted by @coryan in #2309 (comment)
Today, we have the
windows/quickstart-dll
build that tests linking against our installed libraries as a DLL. That's good, but the quickstart builds link against the currently released version of our code, not the version at HEAD.It would be good to create a CI build that tests linking against our code as a DLL/.so using our current HEAD rather than the release. This will allow us to detect errors before we cut the release.
The text was updated successfully, but these errors were encountered: