Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI tests linking against current code as DLL #4090

Closed
devjgm opened this issue May 12, 2020 · 4 comments
Closed

Enable CI tests linking against current code as DLL #4090

devjgm opened this issue May 12, 2020 · 4 comments
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@devjgm
Copy link
Contributor

devjgm commented May 12, 2020

Related to:
Originally posted by @coryan in #2309 (comment)

Today, we have the windows/quickstart-dll build that tests linking against our installed libraries as a DLL. That's good, but the quickstart builds link against the currently released version of our code, not the version at HEAD.

It would be good to create a CI build that tests linking against our code as a DLL/.so using our current HEAD rather than the release. This will allow us to detect errors before we cut the release.

@devjgm devjgm added type: cleanup An internal cleanup or hygiene concern. type: process A process-related concern. May include testing, release, or the like. labels May 12, 2020
@devjgm devjgm added this to the Monorepo: Final Cleanups milestone May 12, 2020
@coryan coryan changed the title Enable CI tests linking against current code as DLL/.so Enable CI tests linking against current code as DLL May 12, 2020
@coryan
Copy link
Contributor

coryan commented May 12, 2020

Changed the title because we have a build for .so: ci/kokoro/docker/shared does that.

@JustinBeckwith JustinBeckwith removed the type: process A process-related concern. May include testing, release, or the like. label May 14, 2020
@coryan
Copy link
Contributor

coryan commented Jun 3, 2020

@devjgm devjgm removed this from the Monorepo: Final Cleanups milestone Jun 5, 2020
@devjgm
Copy link
Contributor Author

devjgm commented Jan 13, 2022

Dropping this. Can reconsider when our deps (e.g. protobuf) support compiling as DLL.

@devjgm devjgm closed this as completed Jan 13, 2022
@coryan
Copy link
Contributor

coryan commented Jan 13, 2022

See #5849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

3 participants