Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch Abseil's base/options.h config file in CI builds #4305

Closed
coryan opened this issue May 29, 2020 · 0 comments · Fixed by #4311
Closed

Patch Abseil's base/options.h config file in CI builds #4305

coryan opened this issue May 29, 2020 · 0 comments · Fixed by #4311
Assignees
@coryan
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Contributor

coryan commented May 29, 2020

As described in abseil/abseil-cpp#696 (and the Abseil docs) we need to patch the base/options.h file when we install Abseil as part of our CI builds.

We probably need to do this in CMake super builds too.
@coryan coryan added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 29, 2020
@coryan coryan self-assigned this May 29, 2020
@coryan coryan mentioned this issue May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: patch Abseil base/options.h to pin C++11 types coryan/google-cloud-cpp
1 participant
@coryan