Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommission the deprecated {Get,Set}IamPolicy functions #5929

Closed
7 tasks
coryan opened this issue Feb 26, 2021 · 1 comment · Fixed by #8667
Closed
7 tasks

Decommission the deprecated {Get,Set}IamPolicy functions #5929

coryan opened this issue Feb 26, 2021 · 1 comment · Fixed by #8667
Assignees
Labels
api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@coryan
Copy link
Contributor

coryan commented Feb 26, 2021

Storage and Bigtable have deprecated functions to manipulate IAM policies designed and written before IAM conditions. These functions no longer work with all IAM policies, and have been deprecated since around 2019-07 (see #2854 and #2900), albeit with just a Doxygen comment.

In #5928 we will have diagnostics issued at the call site for these functions. These functions will be retired, that is, completely removed, on 2022-04-01 or shortly after. The replacement functions are:

  • storage::Client::SetBucketIamPolicy() -> storage::Client::SetNativeBucketIamPolicy()
  • storage::Client::GetBucketIamPolicy() -> storage::Client::GetNativeBucketIamPolicy()
  • bigtable::InstanceAdmin::GetIamPolicy() -> bigtable::InstanceAdmin::GetNativeIamPolicy()
  • bigtable::InstanceAdmin::SetIamPolicy() -> bigtable::InstanceAdmin::SetIamPolicy(std::string const&, google::iam::v1::Policy const&)

We will also need to deprecate and remove (I think as a separate step) the IAM types, namely:

  • google::cloud::IamPolicy
  • google::cloud::IamBindings
  • google::cloud::IamBinding
@coryan coryan added api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern. api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. labels Feb 26, 2021
@coryan coryan self-assigned this Feb 26, 2021
@coryan coryan changed the title Set a date to decommission the deprecated {Get,Set}IamPolicy functions Decommission the deprecated {Get,Set}IamPolicy functions Feb 26, 2021
@coryan coryan removed their assignment Feb 26, 2021
@coryan
Copy link
Contributor Author

coryan commented Feb 24, 2022

We need to revisit this in 2022-04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants