Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove public RowReader ctors #8854

Open
dbolduc opened this issue May 2, 2022 · 1 comment
Open

Deprecate and remove public RowReader ctors #8854

dbolduc opened this issue May 2, 2022 · 1 comment
Labels
api: bigtable Issues related to the Bigtable API. next major: breaking change this is a change that we should wait to bundle into the next major version type: cleanup An internal cleanup or hygiene concern.

Comments

@dbolduc
Copy link
Member

dbolduc commented May 2, 2022

These constructors do not need to be public:

RowReader(std::shared_ptr<DataClient> client, std::string table_name,
RowSet row_set, std::int64_t rows_limit, Filter filter,
std::unique_ptr<RPCRetryPolicy> retry_policy,
std::unique_ptr<RPCBackoffPolicy> backoff_policy,
MetadataUpdatePolicy metadata_update_policy,
std::unique_ptr<internal::ReadRowsParserFactory> parser_factory);
RowReader(std::shared_ptr<DataClient> client, std::string app_profile_id,
std::string table_name, RowSet row_set, std::int64_t rows_limit,
Filter filter, std::unique_ptr<RPCRetryPolicy> retry_policy,
std::unique_ptr<RPCBackoffPolicy> backoff_policy,
MetadataUpdatePolicy metadata_update_policy,
std::unique_ptr<internal::ReadRowsParserFactory> parser_factory);

We will deprecate them and schedule their deletion date as 2023-05-01 (same as #8800)

@dbolduc dbolduc added api: bigtable Issues related to the Bigtable API. type: cleanup An internal cleanup or hygiene concern. labels May 2, 2022
@dbolduc dbolduc added this to the Modernize Bigtable milestone May 2, 2022
@coryan
Copy link
Contributor

coryan commented Sep 14, 2022

These are deprecated, scheduled for removal around 2023-07.

@dbolduc dbolduc added the next major: breaking change this is a change that we should wait to bundle into the next major version label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. next major: breaking change this is a change that we should wait to bundle into the next major version type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants