-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsub): limit ModifyAckDeadlineRequest
size
#10032
fix(pubsub): limit ModifyAckDeadlineRequest
size
#10032
Conversation
Pub/Sub sets a quota of 512KB for `ModifyAckDeadlineRequest` messages. Theoretically we could have gone over that limit, for example, if the application had thousands of messages in memory, and we needed to extend their leases. With this change such requests will be broken into multiple RPCs. It also sets a quota for `AcknowledgeRequest` messages, but always send a single `ack_id` in this case, there is no chance to go over the limit.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 94.22% // Head: 94.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10032 +/- ##
========================================
Coverage 94.22% 94.22%
========================================
Files 1522 1522
Lines 141402 141576 +174
========================================
+ Hits 133233 133404 +171
- Misses 8169 8172 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @coryan)
Pub/Sub sets a quota of 512KB for
ModifyAckDeadlineRequest
messages. Theoretically we could have gone over that limit, for example, if the application had thousands of messages in memory, and we needed to extend their leases. With this change such requests will be broken into multiple RPCs.It also sets a quota for
AcknowledgeRequest
messages, but always send a singleack_id
in this case, there is no chance to go over the limit.Fixes #9471
This change is