Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): tests and samples for DML RETURNING #10233

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Nov 11, 2022

Add tests and samples for GOOGLE_STANDARD_SQL "THEN RETURN" and POSTGRESQL "RETURNING".

Note that Client::ExecuteQuery() can now execute a DML statement with a returning clause.

Previously we added support for RowStream::RowsModified() (#10102), which is now used here.


This change is Reviewable

Add tests and samples for GOOGLE_STANDARD_SQL "THEN RETURN"
and POSTGRESQL "RETURNING".

Note that `Client::ExecuteQuery()` can now execute a DML
statement with a returning clause.

Previously we added support for `RowStream::RowsModified()`
(googleapis#10102), which is now used here.
@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Nov 11, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f5fe8b067563334789d8b5956d48c1952934682c

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 93.97% // Head: 93.84% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (1caaa0e) compared to base (cc21bb0).
Patch coverage: 3.04% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10233      +/-   ##
==========================================
- Coverage   93.97%   93.84%   -0.13%     
==========================================
  Files        1540     1540              
  Lines      141901   142098     +197     
==========================================
+ Hits       133345   133353       +8     
- Misses       8556     8745     +189     
Impacted Files Coverage Δ
google/cloud/spanner/client.h 100.00% <ø> (ø)
google/cloud/spanner/samples/postgresql_samples.cc 0.65% <0.00%> (-0.07%) ⬇️
google/cloud/spanner/samples/samples.cc 62.24% <1.85%> (-1.29%) ⬇️
...r/integration_tests/data_types_integration_test.cc 59.66% <5.74%> (-14.13%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.65% <0.00%> (ø)
google/cloud/completion_queue_test.cc 97.32% <0.00%> (+0.19%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 98.36% <0.00%> (+0.54%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 1caaa0e04e69ea3bf6f8090a141828604eaaf155

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@devbww devbww marked this pull request as ready for review November 11, 2022 21:25
@devbww devbww requested a review from a team as a code owner November 11, 2022 21:25
@snippet-bot
Copy link

snippet-bot bot commented Nov 11, 2022

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@devbww devbww merged commit 1be8dfe into googleapis:main Nov 11, 2022
@devbww devbww deleted the dml-returning branch November 11, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants