Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: group client functions #10268

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Nov 17, 2022

#10265 (comment)

unrelated: these should be ///@{ to actually start a group, ditto for closing the group.


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 338970898864372b79ce0fb47b23be9eabeb9385

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc marked this pull request as ready for review November 17, 2022 22:13
@dbolduc dbolduc requested a review from a team as a code owner November 17, 2022 22:13
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 93.81% // Head: 93.81% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3389708) compared to base (29ffdb9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10268   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files        1565     1565           
  Lines      143754   143754           
=======================================
+ Hits       134863   134868    +5     
+ Misses       8891     8886    -5     
Impacted Files Coverage Δ
...egration_tests/golden/golden_kitchen_sink_client.h 100.00% <ø> (ø)
...tegration_tests/golden/golden_thing_admin_client.h 100.00% <ø> (ø)
generator/internal/client_generator.cc 26.94% <ø> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.81% <0.00%> (-0.55%) ⬇️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+0.58%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
google/cloud/internal/random_test.cc 100.00% <0.00%> (+3.70%) ⬆️
google/cloud/internal/async_connection_ready.cc 93.61% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc enabled auto-merge (squash) November 17, 2022 22:17
@dbolduc dbolduc merged commit a471594 into googleapis:main Nov 18, 2022
@dbolduc dbolduc deleted the dox-group-thingys branch November 18, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants