-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: another pass on authentication components #10300
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.84% // Head: 93.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10300 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 1592 1592
Lines 144868 144868
=======================================
+ Hits 135956 135957 +1
+ Misses 8912 8911 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @coryan)
google/cloud/doc/guac.dox
line 39 at r1 (raw file):
As we mentioned in passing, authentication supports both user accounts and service accounts. These are referred as "principals". User accounts represent a developers, administrator, or any other person who interacts with GCP
s/^a// or s/developers/developer
Code quote:
a developers
I made a pass trying to assume less about what the reader may know about authentication. Motivated by the incorrect magic for numbered items in Doxygen.
6758365
to
c10cd5d
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
I made a pass trying to assume less about what the reader may know about authentication. Motivated by the incorrect magic for numbered items in Doxygen.
This change is