-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support logging for unified Rest credentials #10412
feat: support logging for unified Rest credentials #10412
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.86% // Head: 93.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10412 +/- ##
==========================================
- Coverage 93.86% 93.85% -0.01%
==========================================
Files 1610 1610
Lines 145810 145821 +11
==========================================
- Hits 136860 136859 -1
- Misses 8950 8962 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
std::shared_ptr<oauth2_internal::Credentials> Decorate( | ||
std::shared_ptr<oauth2_internal::Credentials> impl, Options const& opts); | ||
|
||
/// Add only a logging decorator to the credentials. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this could also do with the "if needed" restriction.
"If needed" might also be expanded to something like "if requested by the Options
" in both cases.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Fixes #10316 and fixes #3429
This change is