Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): correct doxygen comments #10500

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 6, 2023

Before:

image

After:

image


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 93.97% // Head: 93.97% // No change to project coverage 👍

Coverage data is based on head (a004299) compared to base (97de9fc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10500   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files        1626     1626           
  Lines      146836   146836           
=======================================
  Hits       137991   137991           
  Misses       8845     8845           
Impacted Files Coverage Δ
...ation_tests/golden/v1/golden_kitchen_sink_client.h 100.00% <ø> (ø)
...ration_tests/golden/v1/golden_thing_admin_client.h 100.00% <ø> (ø)
generator/internal/client_generator.cc 26.94% <ø> (ø)
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.63% <0.00%> (+0.33%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review January 6, 2023 02:12
@coryan coryan requested a review from a team as a code owner January 6, 2023 02:12
@coryan coryan enabled auto-merge (squash) January 6, 2023 02:29
@coryan coryan merged commit 9c56fb5 into googleapis:main Jan 6, 2023
@coryan coryan deleted the fix-generator-doxygen-groups branch January 6, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants