Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interface proto libraries work with older CMake #10636

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 21, 2023

Older versions of CMake are (too) strict about what properties may be attached to an interface library. That was not working for some functions we use with proto libraries.


This change is Reviewable

Older versions of CMake are (too) strict about what properties may be
attached to an interface library.  That was not working for some
functions we use with proto libraries.
@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 93.87% // Head: 93.86% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (48f15b9) compared to base (ef0e4f8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10636      +/-   ##
==========================================
- Coverage   93.87%   93.86%   -0.01%     
==========================================
  Files        1667     1667              
  Lines      150048   150048              
==========================================
- Hits       140853   140849       -4     
- Misses       9195     9199       +4     
Impacted Files Coverage Δ
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
google/cloud/internal/timer_queue.cc 96.10% <0.00%> (-1.30%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 98.78% <0.00%> (-1.22%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 88.62% <0.00%> (-0.67%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.16% <0.00%> (-0.34%) ⬇️
google/cloud/pubsub/samples/samples.cc 87.92% <0.00%> (-0.08%) ⬇️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review January 21, 2023 17:46
@coryan coryan requested a review from a team as a code owner January 21, 2023 17:46
@coryan coryan merged commit ae44fc1 into googleapis:main Jan 21, 2023
@coryan coryan deleted the fix-cmake-and-interface-proto-libraries branch January 21, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants