doc: improve description for "terminate" group #10950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolduc
approved these changes
Feb 24, 2023
google/cloud/terminate_handler.h
Outdated
| * - If the application calls `future<T>::get()`, the library was compiled with | ||
| * exceptions disabled, and (somehow) the future is satisfied with an | ||
| * exception. Note that the library APIs typically return | ||
| * `future<StatusOr<T>>` to avoid this problem, but the application may be |
google/cloud/terminate_handler.h
Outdated
| * | ||
| * - If the application calls `StatusOr<T>::value()`, and the library was | ||
| * compiled with exceptions disabled, and the `StatusOr<T>` contains an error, | ||
| * *then* the function throw an exception to report the error and the function |
There was a problem hiding this comment.
s/throw/throws/
s/and the function/as the function/
Codecov ReportBase: 93.64% // Head: 93.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10950 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 1717 1717
Lines 154915 154915
=======================================
+ Hits 145070 145071 +1
+ Misses 9845 9844 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when writing the docfx stuff. It is also a good test for the new CI images.
This change is