Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mocks): provide access to call options in client tests #11050

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Mar 15, 2023

Fixes #10030

If we think this should be more publicized, say the words and I will add it to our mocking exemplar.

Also, while we are here, put the other mock test in an anonymous namespace.


This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (fc30088) 93.75% compared to head (5cda982) 93.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11050      +/-   ##
==========================================
- Coverage   93.75%   93.75%   -0.01%     
==========================================
  Files        1725     1727       +2     
  Lines      155370   155382      +12     
==========================================
+ Hits       145670   145680      +10     
- Misses       9700     9702       +2     
Impacted Files Coverage Δ
google/cloud/mocks/mock_stream_range_test.cc 100.00% <ø> (ø)
google/cloud/mocks/current_options.h 100.00% <100.00%> (ø)
google/cloud/mocks/current_options_test.cc 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review March 16, 2023 03:24
@dbolduc dbolduc requested a review from a team as a code owner March 16, 2023 03:24
google/cloud/mocks/current_options.h Outdated Show resolved Hide resolved
@dbolduc dbolduc enabled auto-merge (squash) March 16, 2023 03:55
@dbolduc dbolduc merged commit da6fb82 into googleapis:main Mar 16, 2023
@dbolduc dbolduc deleted the mocks-current-options branch March 16, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customers can verify call options
2 participants