-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): use 64-bit API on Windows to get file sizes #11906
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
Thanks for the PR! I made some changes to fit our coding style, I hope you don't mind. |
The changes look good, but we do need you to sign the CLA when you have a chance. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11906 +/- ##
==========================================
- Coverage 93.66% 93.66% -0.01%
==========================================
Files 1838 1838
Lines 166473 166475 +2
==========================================
+ Hits 155931 155932 +1
- Misses 10542 10543 +1
☔ View full report in Codecov by Sentry. |
@HoraceBianchon at this point we are waiting for you to sign the CLA, once you do I will enable the builds again. There is no need to rebase or merge the changes from |
I, mistakenly, committed with my corporate email. |
/gcbrun |
I requested an override and it was granted. Yay! 🎉 Now we wait for the builds to finish. Thanks again for your contribution. |
Thanks |
For files with a size bigger than 2GB (32bit unsigned integer's max value) calculation based on the "::stat" function doesn't work correctly on the Windows operation systems.
I replaced the "::stat" function with "::stat64". For more details on the "::stat", please see link below
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions?view=msvc-170
This change is