feat(bigtable): reverse scans #12022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12022 +/- ##
==========================================
- Coverage 93.72% 93.71% -0.01%
==========================================
Files 2010 2010
Lines 174704 174761 +57
==========================================
+ Hits 163734 163771 +37
- Misses 10970 10990 +20
☔ View full report in Codecov by Sentry. |
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
coryan
approved these changes
Jul 5, 2023
Comment on lines
345
to
352
| for (StatusOr<cbt::Row>& row : table.ReadRows( | ||
| cbt::RowRange::RightOpen("phone#5c10102", "phone#5c10103"), 3, | ||
| cbt::Filter::PassAllFilter(), | ||
| Options{}.set<cbt::ReverseScanOption>(true))) { | ||
| if (!row) throw std::move(row).status(); | ||
| PrintRow(*row); | ||
| } |
There was a problem hiding this comment.
This may be getting too long for a call inside a range for. Consider:
Suggested change
| for (StatusOr<cbt::Row>& row : table.ReadRows( | |
| cbt::RowRange::RightOpen("phone#5c10102", "phone#5c10103"), 3, | |
| cbt::Filter::PassAllFilter(), | |
| Options{}.set<cbt::ReverseScanOption>(true))) { | |
| if (!row) throw std::move(row).status(); | |
| PrintRow(*row); | |
| } | |
| auto rows = table.ReadRows( | |
| cbt::RowRange::RightOpen("phone#5c10102", "phone#5c10103"), 3, | |
| cbt::Filter::PassAllFilter(), | |
| Options{}.set<cbt::ReverseScanOption>(true)); | |
| for (StatusOr<cbt::Row>& row : rows) { | |
| if (!row) throw std::move(row).status(); | |
| PrintRow(*row); | |
| } |
dbolduc
force-pushed
the
bigtable-reverse-scans-pr-3
branch
from
622b99e
to
b666bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12010
ReverseScanOptionand passes its value to the sync/async row readersbool reversefield to theReadRowsParamsNote that the emulator does not yet support returning rows in reverse.
This change is