Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudbuild): promote 2nd gen (repositories) API to GA #12236

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 26, 2023

Fixes #11077


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal July 26, 2023 18:58 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added the api: cloudbuild Issues related to the Cloud Build API. label Jul 26, 2023
@dbolduc dbolduc marked this pull request as ready for review July 26, 2023 19:38
@dbolduc dbolduc requested a review from a team as a code owner July 26, 2023 19:39

// You can override any of the policies in a new client. This new client
// will share the policies from c1 (or c2) *except* for the retry policy.
// will share the policies from c1 (or c2) *except* from the retry policy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"except for" sounded right to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'll send a generator PR.

@dbolduc dbolduc merged commit 95d8c4a into googleapis:main Jul 26, 2023
@dbolduc dbolduc deleted the cloudbuild-v2-ga branch July 26, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudbuild Issues related to the Cloud Build API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Cloud Build v2
2 participants