Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URL encode explicit routing values #12493

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Aug 29, 2023

Part of #12232


This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner August 29, 2023 21:07
@alevenberg alevenberg temporarily deployed to internal August 29, 2023 21:07 — with GitHub Actions Inactive
@alevenberg
Copy link
Member Author

alevenberg commented Aug 29, 2023

I ran GENERATE_GOLDEN_ONLY=true ci/cloudbuild/build.sh -t generate-libraries-pr to generate the generated file change and ci/cloudbuild/build.sh -t asan-pr to verify the change builds

I'm not sure what unit tests I should change for this change

@dbolduc
Copy link
Member

dbolduc commented Aug 29, 2023

  • GENERATE_GOLDEN_ONLY is good for developing, but we should remove it and rerun generate-libraries-pr before sending the PR.
  • I would add a new unit test in golden_kitchen_sink_metadata_decorator_test.cc. Look at the ExplicitRouting* tests for inspiration.
  • We should probably make identical changes to the REST metadata decorator

@alevenberg alevenberg temporarily deployed to internal August 29, 2023 21:24 — with GitHub Actions Inactive
@alevenberg
Copy link
Member Author

alevenberg commented Aug 29, 2023

I did the first two.

We should probably make identical changes to the REST metadata decorator

Maybe in a 2nd PR?

@alevenberg alevenberg temporarily deployed to internal August 29, 2023 21:48 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 88.46% and project coverage change: -0.01% ⚠️

Comparison is base (af7e22c) 93.62% compared to head (f47c1e9) 93.61%.
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12493      +/-   ##
==========================================
- Coverage   93.62%   93.61%   -0.01%     
==========================================
  Files        2039     2039              
  Lines      180676   180697      +21     
==========================================
+ Hits       169153   169168      +15     
- Misses      11523    11529       +6     
Files Changed Coverage Δ
generator/internal/metadata_decorator_generator.cc 34.54% <0.00%> (ø)
...internal/golden_kitchen_sink_metadata_decorator.cc 84.31% <50.00%> (ø)
...sts/golden_kitchen_sink_metadata_decorator_test.cc 99.64% <100.00%> (+0.02%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in a 2nd PR?

SGTM

@alevenberg alevenberg merged commit 5b3e5e2 into googleapis:main Aug 30, 2023
53 checks passed
@alevenberg alevenberg deleted the issue-12232 branch August 30, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants