-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: URL encode explicit routing values #12493
Conversation
I ran I'm not sure what unit tests I should change for this change |
|
I did the first two.
Maybe in a 2nd PR? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12493 +/- ##
==========================================
- Coverage 93.62% 93.61% -0.01%
==========================================
Files 2039 2039
Lines 180676 180697 +21
==========================================
+ Hits 169153 169168 +15
- Misses 11523 11529 +6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in a 2nd PR?
SGTM
Part of #12232
This change is