refactor(cmake)!: only compile protos if asked - logging #12502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #12502 +/- ##
==========================================
- Coverage 93.63% 93.62% -0.01%
==========================================
Files 2043 2043
Lines 180846 180846
==========================================
- Hits 169327 169319 -8
- Misses 11519 11527 +8 ☔ View full report in Codecov by Sentry. |
|
/gcbrun |
coryan
approved these changes
Aug 30, 2023
| @@ -18,7 +18,8 @@ include(GoogleCloudCppLibrary) | |||
|
|
|||
| set(GOOGLE_CLOUD_CPP_SERVICE_DIRS "" "v1/") | |||
|
|
|||
| google_cloud_cpp_add_ga_grpc_library(appengine "App Engine Admin API") | |||
| google_cloud_cpp_add_ga_grpc_library(appengine "App Engine Admin API" | |||
| SHARED_PROTO_DEPS "logging_type") | |||
There was a problem hiding this comment.
I see, logging_type is generated here.
There was a problem hiding this comment.
yeah, it will be generated by whatever comes first in the alphabet, pretty much.
If you -DGOOGLE_CLOUD_CPP_ENABLE=logging (without appengine), then the google/cloud/logging subdirectory will be responsible for generating logging_type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #8022 and #12428
Only
iamremains for both...This change is