fix: restore credential logic #12690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12690 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 2069 2069
Lines 183018 183044 +26
=======================================
+ Hits 171276 171304 +28
+ Misses 11742 11740 -2
☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Sep 21, 2023
| @@ -91,7 +92,8 @@ std::shared_ptr<$stub_rest_class_name$> | |||
| CreateDefault$stub_rest_class_name$(Options const& options) { | |||
| Options opts = options; | |||
| if (!opts.has<UnifiedCredentialsOption>()) { | |||
| opts.set<UnifiedCredentialsOption>(MakeGoogleDefaultCredentials(options)); | |||
| opts.set<UnifiedCredentialsOption>( | |||
There was a problem hiding this comment.
Seems like all the code generated here could go into a common function in google::cloud::internal or google::cloud::rest_internal. There is nothing specific to this stub from lines 93 to 107.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies #12671 and #12672 to only forward the OTel tracing option in cases where the library is responsible for creating the default credentials.
Passing extra options was breaking at least authorized user credential authentication, and possibly more.
This change is