Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): mock for AsyncStreamingReadWriteRpc #12950

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 23, 2023

This class is part of the public API for some *Connection and *Client classes. Applications may need to mock them, we should provide the mock.

I also refactored existing mocks to a single place.

Part of the work for #9134


This change is Reviewable

@coryan coryan temporarily deployed to internal October 23, 2023 17:13 — with GitHub Actions Inactive
This class is part of the public API for some `*Connection` and
`*Client` classes. Applications may need to mock them, we should provide
the mock.

I also refactored existing mocks to a single place.
@coryan coryan force-pushed the feat-common-mock-async-reader-writer-rpc branch from a1ccfbd to 45ad3cf Compare October 23, 2023 17:31
@coryan coryan temporarily deployed to internal October 23, 2023 17:31 — with GitHub Actions Inactive
@coryan coryan marked this pull request as ready for review October 23, 2023 17:45
@coryan coryan requested a review from a team as a code owner October 23, 2023 17:45
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (669b751) 93.59% compared to head (45ad3cf) 93.59%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #12950    +/-   ##
========================================
  Coverage   93.59%   93.59%            
========================================
  Files        2067     2068     +1     
  Lines      180575   180686   +111     
========================================
+ Hits       169003   169110   +107     
- Misses      11572    11576     +4     
Files Coverage Δ
...ration_tests/tests/mock_golden_kitchen_sink_stub.h 77.27% <ø> (+2.27%) ⬆️
...d/internal/async_read_write_stream_logging_test.cc 100.00% <ø> (ø)
...d/internal/async_read_write_stream_tracing_test.cc 100.00% <ø> (ø)
.../cloud/mocks/mock_async_streaming_read_write_rpc.h 100.00% <ø> (ø)
...e/cloud/pubsub/internal/subscriber_stub_factory.cc 100.00% <100.00%> (ø)
...ud/pubsublite/internal/partition_publisher_test.cc 99.24% <ø> (ø)
...l/resumable_async_streaming_read_write_rpc_test.cc 99.87% <ø> (ø)
...ud/pubsub/internal/subscriber_stub_factory_test.cc 96.03% <96.03%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan enabled auto-merge (squash) October 23, 2023 18:00
@coryan coryan merged commit ebf9e56 into googleapis:main Oct 23, 2023
54 checks passed
@coryan coryan deleted the feat-common-mock-async-reader-writer-rpc branch October 23, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants