feat(otel): add Makefile #13177
Merged
feat(otel): add Makefile #13177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13177 +/- ##
==========================================
- Coverage 92.99% 92.99% -0.01%
==========================================
Files 2138 2138
Lines 185971 185971
==========================================
- Hits 172952 172949 -3
- Misses 13019 13022 +3 ☔ View full report in Codecov by Sentry. |
dbolduc
force-pushed
the
otel-make-dev-2
branch
from
6f83e7f
to
6dadba8
Compare
alevenberg
approved these changes
Nov 21, 2023
coryan
approved these changes
Nov 21, 2023
|
|
||
| # Configuration variables to compile and link against the Google Cloud | ||
| # OpenTelemetry Exporter library and the Google Cloud Storage client. | ||
| CLIENT_MODULE := google_cloud_cpp_opentelemetry google_cloud_cpp_storage |
There was a problem hiding this comment.
s/CLIENT_MODULE/EXAMPLE_MODULES/ ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10795
Add a Makefile to the OpenTelemetry exporter library quickstart, to show how to build with
make(1).Also, now that
opentelemetry-cppinstalls its ownopentelemetry_*.pcmodules with proper compiler definitions, we no longer need to defineHAVE_ABSEILfor them in our code. Yay.This change is