-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): returnable argument to .then()
#13316
Merged
coryan
merged 12 commits into
googleapis:main
from
coryan:fix-common-future-continuation-returns-argument
Dec 18, 2023
Merged
fix(common): returnable argument to .then()
#13316
coryan
merged 12 commits into
googleapis:main
from
coryan:fix-common-future-continuation-returns-argument
Dec 18, 2023
Commits on Dec 15, 2023
-
fix(common): returnable argument to
.then()
The main motivation for these changes is to support: ```cc future<T> F(future<T> f) { return f.then([](auto g) { /* stuff */; return g; }); } ``` This is common enough, and was broken for fairly obscure reasons. I completely changed the implementation of `.then()`. It was too hacky to do something else, and I think the new implementation is simpler too.
Configuration menu - View commit details
-
Copy full SHA for d0df6ed - Browse repository at this point
Copy the full SHA d0df6edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 567c662 - Browse repository at this point
Copy the full SHA 567c662View commit details -
Configuration menu - View commit details
-
Copy full SHA for c83118d - Browse repository at this point
Copy the full SHA c83118dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04c5518 - Browse repository at this point
Copy the full SHA 04c5518View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dbc412 - Browse repository at this point
Copy the full SHA 2dbc412View commit details -
Configuration menu - View commit details
-
Copy full SHA for bad023c - Browse repository at this point
Copy the full SHA bad023cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e1f8f8 - Browse repository at this point
Copy the full SHA 1e1f8f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92209f0 - Browse repository at this point
Copy the full SHA 92209f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 630e0c7 - Browse repository at this point
Copy the full SHA 630e0c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59bd41f - Browse repository at this point
Copy the full SHA 59bd41fView commit details
Commits on Dec 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0fbf2e7 - Browse repository at this point
Copy the full SHA 0fbf2e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb4fa2e - Browse repository at this point
Copy the full SHA eb4fa2eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.