Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): returnable argument to .then() #13316

Merged

Commits on Dec 15, 2023

  1. fix(common): returnable argument to .then()

    The main motivation for these changes is to support:
    
    ```cc
    future<T> F(future<T> f) {
      return f.then([](auto g) { /* stuff */; return g; });
    }
    ```
    
    This is common enough, and was broken for fairly obscure reasons.  I
    completely changed the implementation of `.then()`. It was too hacky to
    do something else, and I think the new implementation is simpler too.
    coryan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d0df6ed View commit details
    Browse the repository at this point in the history
  2. Fix spelling problems

    coryan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    567c662 View commit details
    Browse the repository at this point in the history
  3. Suppress warnings with GCC

    coryan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c83118d View commit details
    Browse the repository at this point in the history
  4. API update

    coryan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    04c5518 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2dbc412 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bad023c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1e1f8f8 View commit details
    Browse the repository at this point in the history
  8. Fix abandon()

    coryan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    92209f0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    630e0c7 View commit details
    Browse the repository at this point in the history
  10. Revert debugging changes

    coryan committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    59bd41f View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Address review comments

    coryan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0fbf2e7 View commit details
    Browse the repository at this point in the history
  2. Address review comments

    coryan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    eb4fa2e View commit details
    Browse the repository at this point in the history