Implement support for IAM conditions. #2854
Conversation
This fixes googleapis#2732 This is basically a couple of helpers for constructing and printing relevant protos.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2854 +/- ##
==========================================
- Coverage 89.33% 89.22% -0.12%
==========================================
Files 296 297 +1
Lines 19704 19736 +32
==========================================
+ Hits 17603 17609 +6
- Misses 2101 2127 +26
Continue to review full report at Codecov.
|
coryan
changed the title
|
I've updated the ABI expectations, but TBH, I don't understand what it's complaining about. It claims that one symbol is removed in the "Source compatibility" category (either I'm reading it wrong or it doesn't specify which one). When locally generating these reports, I get 100% compatibility and the PR doesn't remove anything, so I'll claim it a false positive. |
The checker claims that google::iam::v1::_Binding_default_instance_ has been removed, which is false.
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dopiera)
google/cloud/bigtable/expr.h, line 1 at r1 (raw file):
// copyright 2019 google llc
nit: the capitalization is all wrong for the copyright boilerplate.
google/cloud/bigtable/expr.h, line 18 at r1 (raw file):
#define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_BIGTABLE_EXPR_H_ #include "google/type/expr.pb.h"
This should be <google/type/expr.pb.h>.
google/cloud/bigtable/instance_admin.h, line 907 at r1 (raw file):
* @return Policy the full IAM policy for the instance. * * @deprecated this function is deprecated; it doesn't support conditional
We should consider using the [[deprecated]] attribute for the function. Maybe a TODO and a bug?
There was a problem hiding this comment.
Reviewable status: 11 of 13 files reviewed, 2 unresolved discussions (waiting on @coryan)
google/cloud/bigtable/expr.h, line 18 at r1 (raw file):
Previously, coryan (Carlos O'Ryan) wrote…
This should be
<google/type/expr.pb.h>.
Done.
google/cloud/bigtable/instance_admin.h, line 907 at r1 (raw file):
Previously, coryan (Carlos O'Ryan) wrote…
We should consider using the
[[deprecated]]attribute for the function. Maybe a TODO and a bug?
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved
This fixes #2732
This is basically a couple of helpers for constructing and printing
relevant protos.
This change is