Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: deprecate some IAM types #6069

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Mar 18, 2021

These types are only used in (already) deprecated IAM functions. I
wanted to deprecate each type, but that requires too many changes to
disable the diagnostics where we use the types. Instead I updated the
documentation and used deprecation attributes in the functions a
customer would use if they used the type.

Part of the work for #5929


This change is Reviewable

These types are only used in (already) deprecated IAM functions. I
wanted to deprecate each type, but that requires too many changes to
disable the diagnostics where we use the types. Instead I updated the
documentation and used deprecation attributes in the functions a
customer would use if they used the type.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #6069 (06e1c16) into master (a935d32) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6069      +/-   ##
==========================================
- Coverage   95.79%   95.79%   -0.01%     
==========================================
  Files        1167     1167              
  Lines      104149   104155       +6     
==========================================
+ Hits        99772    99777       +5     
- Misses       4377     4378       +1     
Impacted Files Coverage Δ
google/cloud/iam_bindings.cc 95.55% <ø> (ø)
google/cloud/iam_bindings_test.cc 98.07% <ø> (ø)
google/cloud/iam_policy.h 100.00% <ø> (ø)
google/cloud/storage/internal/bucket_requests.cc 100.00% <ø> (ø)
...gle/cloud/storage/internal/bucket_requests_test.cc 97.65% <ø> (ø)
google/cloud/version.h 100.00% <ø> (ø)
google/cloud/iam_binding.h 100.00% <100.00%> (ø)
google/cloud/iam_bindings.h 96.00% <100.00%> (+1.26%) ⬆️
google/cloud/spanner/samples/samples.cc 84.30% <0.00%> (-0.15%) ⬇️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 91.83% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a935d32...06e1c16. Read the comment docs.

@coryan coryan marked this pull request as ready for review March 18, 2021 20:24
@coryan coryan requested a review from a team as a code owner March 18, 2021 20:24
@coryan coryan merged commit a763634 into googleapis:master Mar 18, 2021
@coryan coryan deleted the cleanup-deprecate-iam-bindings branch March 18, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants