Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(common): move iam_updater.h to google_cloud_cpp_grpc_utils #7287

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Sep 8, 2021

Move the new iam_updater.h header from google_cloud_cpp_common to
google_cloud_cpp_grpc_utils to mirror its dependence on iam_protos.


This change is Reviewable

Move the new `iam_updater.h` header from `google_cloud_cpp_common` to
`google_cloud_cpp_grpc_utils` to mirror its dependence on `iam_protos`.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 1ecc8f757438c496b7df646f09680c921668e395

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #7287 (1ecc8f7) into main (8459046) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7287   +/-   ##
=======================================
  Coverage   93.77%   93.78%           
=======================================
  Files        1338     1338           
  Lines      115479   115479           
=======================================
+ Hits       108295   108297    +2     
+ Misses       7184     7182    -2     
Impacted Files Coverage Δ
...le/cloud/storage/internal/curl_download_request.cc 88.10% <0.00%> (-1.12%) ⬇️
google/cloud/completion_queue_test.cc 96.95% <0.00%> (-0.20%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.02% <0.00%> (+0.24%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.51% <0.00%> (+2.19%) ⬆️
google/cloud/storage/internal/curl_handle.h 82.85% <0.00%> (+2.85%) ⬆️
google/cloud/grpc_error_delegate.cc 100.00% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8459046...1ecc8f7. Read the comment docs.

@devbww devbww marked this pull request as ready for review September 8, 2021 01:52
@devbww devbww requested a review from a team as a code owner September 8, 2021 01:52
@devbww devbww merged commit b3655b0 into googleapis:main Sep 8, 2021
@devbww devbww deleted the iam-updater-grpc branch September 8, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants