Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): polling policy clones initial state #7858

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jan 10, 2022

Fixes #7853

Use the initial state of the polling policy as the prototype for clones. Add documentation and unit tests for GenericPollingPolicy.

Fixes #7562

@devbww made the connection to the Spanner samples.cc flake.

We make the polling policy out of a retry policy with a 60 minute timeout at the start of the test. But then when we clone the polling policy for individual polling loops, we are just reusing the original retry policy. So the test goes on, but after 60 mins, the retry policy is exhausted, and any polling loop will be terminated.

CloneWithPointers is the test for this flake, which now passes, but would previously have failed.


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b997d1b14116567344f658f24cc737208725fbb8

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #7858 (b997d1b) into main (19b7ec7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7858   +/-   ##
=======================================
  Coverage   95.12%   95.13%           
=======================================
  Files        1284     1285    +1     
  Lines      116200   116280   +80     
=======================================
+ Hits       110539   110619   +80     
  Misses       5661     5661           
Impacted Files Coverage Δ
google/cloud/polling_policy.h 100.00% <100.00%> (ø)
google/cloud/polling_policy_test.cc 100.00% <100.00%> (ø)
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (-0.57%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 90.10% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b7ec7...b997d1b. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review January 10, 2022 15:26
@dbolduc dbolduc requested a review from a team as a code owner January 10, 2022 15:26
@dbolduc dbolduc merged commit 6c793d4 into googleapis:main Jan 10, 2022
@dbolduc dbolduc deleted the generic-polling-policy-clone branch January 10, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants