Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(common)!: remove legacy IAM classes #8667

Merged
merged 3 commits into from
Apr 2, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Apr 2, 2022

Fixes #5929


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 6b5d2c73bd0fb1dd1e6d2839bc7a439cce098011

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #8667 (e757965) into main (7bac6b9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main    #8667    +/-   ##
========================================
  Coverage   93.41%   93.42%            
========================================
  Files        1461     1456     -5     
  Lines      123977   123808   -169     
========================================
- Hits       115815   115666   -149     
+ Misses       8162     8142    -20     
Impacted Files Coverage Δ
google/cloud/bigtable/instance_admin.h 100.00% <ø> (ø)
google/cloud/bigtable/table_admin.h 100.00% <ø> (ø)
google/cloud/bigtable/version.h 100.00% <ø> (ø)
google/cloud/storage/client.h 99.79% <ø> (ø)
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (-0.57%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (-0.25%) ⬇️
google/cloud/completion_queue_test.cc 97.13% <0.00%> (+0.19%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 97.91% <0.00%> (+0.69%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bac6b9...e757965. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review April 2, 2022 01:55
@dbolduc dbolduc requested a review from a team as a code owner April 2, 2022 01:55
@dbolduc dbolduc enabled auto-merge (squash) April 2, 2022 01:55
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 419a3b15f2a05f7e64d4eaa323025394c195f970

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: e75796565f98bac98c15f29ca7ff9da1f34d6ba0

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc merged commit bedfd74 into googleapis:main Apr 2, 2022
@dbolduc dbolduc deleted the remove-deprecated-IAM-classes branch April 2, 2022 18:35
devbww added a commit to devbww/google-cloud-cpp that referenced this pull request May 4, 2022
`GOOGLE_CLOUD_CPP_BIGTABLE_IAM_DEPRECATED` disappeared in googleapis#8652.
`GOOGLE_CLOUD_CPP_IAM_DEPRECATED` disappeared in googleapis#8667.
devbww added a commit that referenced this pull request May 4, 2022
`GOOGLE_CLOUD_CPP_BIGTABLE_IAM_DEPRECATED` disappeared in #8652.
`GOOGLE_CLOUD_CPP_IAM_DEPRECATED` disappeared in #8667.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decommission the deprecated {Get,Set}IamPolicy functions
3 participants